Hey this is fantastic! Tried 2019.08.27.0251 remotely in the web interface, and it works really well for 1080i content. With my weak 5mpbs upload speed, I had to dial it back to 720p3mbps. Monitoring channels-dvr upload usage revealed about 350-420KB/s or 2.8-3.3Mbps, so it seems the hardware encoder is respecting the streaming rate. Quality is decent. It loads pretty quickly (5-10s) and is quite stable at the 720p3mbps (or 4mpbs) setting for 1080i content. Thanks to your hardware scaler, CPU stays below 150%, and often less than 100%. That means the Pi will have plenty of time to do other things. Truly remarkable progress here!
Unfortunately 720p content is a different story — it either stalls regularly, or refuses to start playing entirely. While attempting to stream 720p content, CPU is humming along at 125% or less (seems about right), but what's strange is it's completely saturating my upstream pipe at ~570KB/s for minutes at a time. Kind of seems like it isn't respecting the data rate limits for 720p content when the scaler isn't used.
Interestingly 480p also seems close to correct for upload speed (assuming a 720p 4mbps corresponds to about 1.8mpbs 480p). I would guess you don't "upscale" so not sure why 720p has such specific issues; maybe some asymmetry in how the encoder is setup with and without scaling. Also odd because 720p content used to be the easiest!
Anyway, great progress. Looking forward to seeing how this evolves.