I would say it depends on your needs and usage level.
If you need a very large amount of space, like to store many recordings, or have a Local Content Library, and very very frequently record things, then a large HDD would be best overall. Large HDDs are pretty cheap these days vs large SSDs are still much more expensive.
If you do not need a large amount of storage, have average recording habits, a ssd is fine.
I have had a Samsung 840 Evo 2TB ssd in use as my main drive for Channels DVR, and Emby before that, for 5yrs at least...drive is still fine.