Commercial detection not working on HEVC recordings

I didn't have any old atsc3 recordings but I just scheduled 3 over the next 2 hours. I'll let you know how she works...

1 Like
2022/02/08 15:44:07.528233 [DVR] Running commercial detection on file 1203 (TV/American Auto/American Auto S01E01 Pilot 2021-12-13-2101.mpg)
2022/02/08 15:53:49.219118 [DVR] Commercial detection for American Auto S01E01 Pilot 2021-12-13-2101.mpg finished with 4 markers in 9m41.69098061s.

For reference i5-10400 with 4 threads enabled for commercial detection. Typically detection takes about 1min 30sec for an hour show. This show is 30min. The good is it picked up 4 markers when it had zero markers before. Haven’t been able to check accuracy though

2 Likes

Pretty accurate on my side. I recorded 3 different shows and everything worked great. Took about 8min for a 30 min show. Normally it takes less than a minute using 7 threads on my i7 but the time difference is no big deal at all.

1 Like

Great. I'm uploading v2022.02.08.2301 which should improve performance a bit.

Old version 2022.02.08.2034:
1hour 720p 9m59.211000273s.
30min 1080p 9m41.69098061s
1hour 1080p 13m59.852850703s

New version v2022.02.08.2301
1hour 720p. 9m59.352219422s
30min 1080p 9m43.130877147s
1hour 1080p 14m1.386807227s

Thanks for implementing this it will be awesome to finally have comskip on atsc3. If it takes 10 minutes, so be it. Good work!!

1 Like

Never mind missed the logging part

This 32 minute recording made in the DVR server version 2002.02.07.2217 had no markers at all.

Then I updated the server to 2022.02.09.0020 and ran commercial re-detect on it. This is on a 2021 iMac (2.9 GHz Intel Core i5.)

2022/02/08 20:26:42.399724 [DVR] Running commercial detection on file 17431 (TV/25 Words or Less/25 Words or Less S03E96 2022-02-08-1359.mpg)

2022/02/08 20:40:11.981932 [DVR] Commercial detection for 25 Words or Less S03E96 2022-02-08-1359.mpg finished with 4 markers in 13m29.621669249s (3 threads).

I'm very happy to have comskip on these HEVC recordings!

1 Like

@tmm1 Any chance the commercial editing can be updated to show thumbnails for ATSC3?

Huh it should be showing them.

It shows thumbnails for your recordings right?

Is that happening for every single recording? Any errors in the log?

No errors in the log. Thumbnails show for the recordings but the thumbnails for the commercial detection don't show on any recorded shows

Are you able to right click on where one of those images should be and open in new tab to see if there's an error or something?

I don't have the option to open in a new tab unfortunately. FYI I also just noticed that the processed time is UTC. Looks like I did this 5 hours ago and I just did it a couple of minutes ago.

Try http://x.x.x.x:8089/dvr/files/9520/comskip/preview/8.27

@tmm1 I get a 404 when I try to go to
http://192.168.12.30:8089/dvr/files/9520/comskip/preview/8.27

Would the comskip.ini file be helpful?

Maybe you deleted that recording already?

Nah it's still there

In the Logs/comskip/9520/ are there any preview-*.jpg files?

none at all, I randomly checked other directories and couldnt find any preview files either

@rice @fofer are you having this same issue in the commercial editor?

Actually I do have other recordings (ATSC1) that show the preview files. I think I was looking at imports or something... So its just ATSC 3.0 that are having preview issues