Comskip @ 4k

Since Channels DVR uses comskip version 0.82.005, is there any chance of getting it updated to work with 4K 10bit HDR content?

Changes on 0.82.012
 - Added support for 10bit video decoders
Changes on 0.82.011
 - Upgraded to ffmpeg 4.3 decoders
 - Maximum video size increased to support 4K video
Changes on 0.82.010
 - Upgraded to latest build of ffmpeg decoders
 - Bug solved: Sometimes Comskip hangs at the end of processing a recording.
Changes on 0.82.009
 - Max video size increased to 4000x2400 to allow processing of 4k video
2 Likes

We already do, that fix came from us.

1 Like

Hmm.
Log is showing this and detection errors out with rest of log filled with "Panic: illegal height (2160), width (3840) or frame period (3840)"

################################################################
Generated using donator Comskip 0.82.005
Time at start of run:
Thu Jan 12 16:50:37 2023
################################################################
Mpeg:	/volume1/chDVRtve/TV/College Basketball/College Basketball Minnesota at Ohio State 2023-01-12-1640.mpg
Exe	comskip.exe
Logo:	/volume1/chDVRtve/Logs/comskip/1499/video.logo.txt
Ini:	comskip.ini

Detection Methods to be used:
	1) Black Frame
	2) Logo - Give up after 2000 seconds
	3) Resolution Change
	4) Closed Captions
	5) Aspect Ratio
	6) Silence


ComSkip throttles back from -0001 to -0001.
The time is now 1650 so it's full speed ahead!

Settings
...

[mpegts @ 0x73ede80] Before avformat_find_stream_info() pos: 0 bytes read:32768 seeks:0 nb_streams:4
[mpegts @ 0x73ede80] start time for stream 1 is not set in estimate_timings_from_pts
[mpegts @ 0x73ede80] stream 1 : no TS found at start of file, duration not set
[mpegts @ 0x73ede80] Could not find codec parameters for stream 1 (Audio: aac ([15][0][0][0] / 0x000F), 0 channels): unspecified sample format
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[mpegts @ 0x73ede80] After avformat_find_stream_info() pos: 0 bytes read:5787792 seeks:3 frames:116
Input #0, mpegts, from '/volume1/chDVRtve/TV/College Basketball/College Basketball Minnesota at Ohio State 2023-01-12-1640.mpg':
  Duration: 00:10:33.35, start: 1.824789, bitrate: 18648 kb/s
  Program 1 
  Stream #0:0[0x1e1]: Video: hevc (Main 10) ([36][0][0][0] / 0x0024), yuv420p10le(tv, bt2020nc/bt2020/smpte2084, progressive), 3840x2160 [SAR 1:1 DAR 16:9], Closed Captions, 59.94 fps, 59.94 tbr, 90k tbn, 59.94 tbc
  Stream #0:1[0x1e2](eng): Audio: aac ([15][0][0][0] / 0x000F), 0 channels
  Stream #0:2[0x1e3]: Data: scte_35
  Stream #0:3[0x1e4]: Data: timed_id3 (ID3  / 0x20334449)
Frame Rate set to 59.940 f/s
Panic: illegal height (2160), width (3840) or frame period (3840)

Initial video pts =      0.017
Panic: illegal height (2160), width (3840) or frame period (3840)

Initial video pts =      0.033
Panic: illegal height (2160), width (3840) or frame period (3840)
Panic: illegal height (2160), width (3840) or frame period (3840)
Panic: illegal height (2160), width (3840) or frame period (3840)
...

Here's the override comskip.ini file I use

verbose=10
detect_method=123 ;; everything but scenechange
punish_no_logo=0
cc_correct_type_modifier=1
length_nonstrict_modifier=1.5 ;; required before below due to comskip.ini parsing bug
combined_length_nonstrict_modifier=1
min_show_segment_length=222
min_commercialbreak=25
use_existing_logo_file=0
logo_fraction=0.39
delete_logo_file=1
output_vdr=1
output_edl=1
output_ffmeta=1
output_ffsplit=1
output_videoredo3=1
videoredo_offset=0
thread_count=2
lowres=10

Update: I ran the public 0.82.012 version from my Windows PC and it was able to process the 4K/HDR 10bit recording without errors, other than not identifying any audio track in the recording.

Testing.
Is it still the case where more threads won't help?
https://www.kaashoek.com/comskip/viewtopic.php?p=9284#p9284

Yes still the case

2 Likes

Ouch!
Took 97 minutes to process the 10.5 minute recording and find no commercials.
It was unable to find the audio channel.

I think I'll disable using comskip for 4K/HDR recordings for now!

1 Like

Was this on FS1? ... because when I record First Things First and it stops playing in the middle and gets stuck. I can never get a clean recording from FS1 unless I use my Prime.

1 Like

Yep

Pretty sure an M1 Mac would fly through it in a couple minutes, but not my underpowered NAS.

I don’t know about that. If it’s anything like atsc3 hevc I see diminishing returns each core I throw at it. It’s pretty much the same at 10 as 6 cores. I’m running a comskip right now(6 cores i5-10400) on that game so we will see. My recording is 2hrs long. Will post the time when it’s done.

This is the bottleneck for 10bit HEVC/HDR that only uses a single thread

I'll check for your reply tomorrow during lunch :laughing:

2 Likes

I used my Win-10 laptop yesterday (11th Gen Intel Core i7-1165G7 @ 2.80GHz)
Running the public (not donor) comskip version 0.82.012
Set for 6 threads, it never used more than 12% CPU and took 79 minutes.

It’s done

2023/01/13 18:26:35.869751 [DVR] Commercial detection failed for College Basketball Minnesota at Ohio State 2023-01-12-1843.mpg with exit status 1

Did you get the same in your comskip log where it couldn't find the audio track?

[mpegts @ 0x239bcec0] start time for stream 1 is not set in estimate_timings_from_pts
[mpegts @ 0x239bcec0] stream 1 : no TS found at start of file, duration not set
[mpegts @ 0x239bcec0] Could not find codec parameters for stream 1 (Audio: aac ([15][0][0][0] / 0x000F), 0 channels): unspecified sample format

Input #0, mpegts, from '/volume1/chDVRtve/TV/College Basketball/College Basketball Minnesota at Ohio State 2023-01-12-1640.mpg':
  Duration: 00:10:33.35, start: 1.824789, bitrate: 18648 kb/s
  Program 1 
  Stream #0:0[0x1e1]: Video: hevc (Main 10) ([36][0][0][0] / 0x0024), yuv420p10le(tv, bt2020nc/bt2020/smpte2084, progressive), 3840x2160 [SAR 1:1 DAR 16:9], Closed Captions, 59.94 fps, 59.94 tbr, 90k tbn, 59.94 tbc
  Stream #0:1[0x1e2](eng): Audio: aac ([15][0][0][0] / 0x000F), 0 channels
  Stream #0:2[0x1e3]: Data: scte_35
  Stream #0:3[0x1e4]: Data: timed_id3 (ID3  / 0x20334449)

Parsed 37959 video frames and 0 audio frames at     6.50 fps

After Sorting - 1
--------------
Audio channels   0 found on  37959 frames totalling 	100.0%

Where would I look after choosing log folder for that game ? Video.log or video.txt file ? Is there easier way to view it?:8089/……3870
I’m not at home so it’s a lot harder than looking on a desktop

Video.log
or Edit Commercials and click the link for comskip.log

It is extremely long file. But I think this is what you want?

That looks normal and correct.
Not sure why mine is different.
Mediainfo, TSReader and VideoReDo all identify the audio in my recording.
Will have to see tomorrow on the Fox Football recording.

I can’t find any noticeable errors other than channel log’s saying failed. May be you can

Thanks, but no need for that.
comskip identified stereo audio in your recording, but not mine.
Maybe because mine was only 10 minutes long. Don't know why.